admin/crm_ecosplay
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
323 Commits 1 Branch 0 Tags
aa18cb834db5ca72b47764e09df1002566688d04
Commit Graph

323 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Serreau Jovann
06494322bd fix: texte echeancier - configuration prelevements apres signature 
Remplace "vous autorisez le prelevement automatique" par
"un email vous sera envoye pour effectuer la configuration
des prelevements automatiques" dans tous les templates.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 20:15:54 +02:00
Serreau Jovann
19e160c6f8 fix: ajout majoration 5% dans email signature echeancier 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 20:14:53 +02:00
Serreau Jovann
6fe95b5c42 feat: majoration 5% affichee partout (PDF, email, admin, page client) 
Entite Echeancier :
- MAJORATION_RATE = 0.05 constante
- getMajoration() : montant de la majoration
- getTotalWithMajoration() : total creance + 5%
- getMonthlyAmount() : calcule sur le total majore

Controller create :
- Echeances calculees sur le total majore (pas le total brut)

PDF EcheancierPdf :
- Bloc resume : creance, majoration (rouge), total a payer
- Tableau total : "TOTAL (creance + majoration 5%)"

Email proposition :
- Lignes creance, majoration +5% (rouge), total a payer

Page process (client) :
- 4 colonnes : creance, majoration 5%, total a payer, mensualite

Admin show :
- Carte "Creance + majoration 5%" avec detail

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 20:14:11 +02:00
Serreau Jovann
6370b8481f fix: email echeancier - un seul bouton "Voir la proposition" (pas de lien signer) 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 20:10:11 +02:00
Serreau Jovann
fe630317d3 feat: page process echeancier + bouton signature unique + email details 
- Page publique /echeancier/process/{id} avec detail complet avant signature
  (motif, resume, tableau echeances, conditions)
- Redirige vers page signed si deja signe/actif/termine
- Bouton unique "Envoyer pour signature" / "Renvoyer signature" selon state
- Suppression bouton "Envoyer proposition" (remplace par signature directe)
- Email signature : ajout bouton "Voir les details" + lien processUrl

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 20:09:24 +02:00
Serreau Jovann
3c5d9c0f94 fix: auto-generation PDF a la creation echeancier + bouton regenerer 
- create() genere le PDF automatiquement apres creation
- Extraction generateEcheancierPdf() methode privee reutilisable
- Bouton "Regenerer PDF" (jaune) si PDF existe, "Generer PDF" sinon
- Bouton visible dans tous les etats sauf cancelled/completed
- Redirect vers show apres creation (au lieu de l'onglet client)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 20:04:24 +02:00
Serreau Jovann
46ddb5786a feat: PDF echeancier + signature DocuSeal + email + page client 
EcheancierPdf :
- PDF FPDF avec bloc legal, description, tableau echeances, conditions
- 2 champs signature DocuSeal : Company (auto-signe E-Cosplay) + First Party (client)

Controller :
- generate-pdf : genere le PDF via EcheancierPdf + Vich upload
- send-signature : envoie PDF a DocuSeal (2 parties), email avec bouton signer
- resend : renvoie email proposition
- DocuSealService.getLogoBase64 rendu public

EcheancierProcessController (public) :
- /echeancier/signed/{id} : callback post-signature, passe state a signed

Templates :
- echeancier/signed.html.twig : page confirmation signature client
- emails/echeancier_signature.html.twig : email avec bouton signer
- admin/echeancier/show : boutons generer PDF, voir PDF, envoyer proposition,
  envoyer signature, renvoyer, PDF signe, activer Stripe, annuler

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 19:53:10 +02:00
Serreau Jovann
978fcb9156 feat: methode paiement echeancier liee aux echeanciers du client 
- Ajout methode "Echeancier" dans le select du modal paiement manuel
- Select dynamique des echeanciers du client (visible si methode=echeancier)
- AdvertPayment : relation ManyToOne vers Echeancier (nullable)
- Controller : lie l'echeancier au paiement, label avec description

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 19:45:44 +02:00
Serreau Jovann
8d91795250 fix: paiement manuel partiel - un avis peut avoir plusieurs paiements 
- Ne passe en 'accepted' que quand totalPaid >= totalTtc
- Facture generee uniquement quand totalement paye
- Message flash avec reste a payer si paiement partiel
- Modal affiche "Deja paye / Reste" si paiements existants
- Bouton visible sur avis send + tout state non cancel/accepted

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 19:42:53 +02:00
Serreau Jovann
49a4cf3ec2 feat: enregistrement paiement manuel sur avis de paiement 
- Bouton "Enregistrer paiement" sur les avis au state 'send'
- Modal avec montant, methode (virement/cheque/especes/CB externe/autre),
  reference optionnelle
- Route manualPayment : cree AdvertPayment, passe avis en accepted,
  genere facture payee, indexe Meilisearch
- Methodes : virement, cheque, especes, CB terminal externe, autre

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 19:40:05 +02:00
Serreau Jovann
f0bdc60b99 feat: webhook Stripe invoice.paid/failed pour echeancier + fix DevisController 
Webhook Stripe :
- handleInvoicePaid : trouve echeancier par subscriptionId, marque la
  prochaine ligne en attente comme payee, envoie email confirmation,
  passe echeancier en 'completed' si toutes les echeances payees
- handleInvoiceFailed : marque ligne en echec avec raison, envoie email
  echec au client + notification admin, passe en 'default' apres 2 echecs

Emails :
- echeancier_echeance_payee.html.twig : confirmation prelevement reussi
- echeancier_echeance_echec.html.twig : notification echec prelevement

Fix DevisController :
- Route #[Route] deplacee de sendDevisSignEmail vers createAdvert
  (erreur "controller not callable" corrigee)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 19:35:42 +02:00
Serreau Jovann
0f2712bb36 feat: echeancier de paiement (entites + controller + template + email) 
Entites :
- Echeancier : customer, description, totalAmountHt, state (draft/send/
  signed/active/completed/cancelled/default), stripeSubscriptionId,
  stripePriceId, submitterCompanyId/CustomerId, 3 PDF Vich (unsigned/
  signed/audit), submissionId (DocuSeal)
- EcheancierLine : position, amount, scheduledAt, state (prepared/ok/ko),
  stripeInvoiceId, paidAt, failureReason

Controller EcheancierController :
- create : cree echeancier avec N echeances mensuelles (montant reparti)
- show : detail echeancier avec progression
- send : envoie email proposition au client
- cancel : annule echeancier + subscription Stripe
- activate : cree Stripe Subscription (price + subscription + cancel_at)

Templates :
- admin/echeancier/show.html.twig : detail avec resume, progression,
  tableau echeances, actions (envoyer/activer/annuler)
- admin/clients/show.html.twig : onglet echeancier avec liste + modal creation
- emails/echeancier_proposition.html.twig : email proposition avec detail

Vich mappings : echeancier_pdf, echeancier_signed_pdf, echeancier_audit_pdf

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 19:31:28 +02:00
Serreau Jovann
f56099f557 fix: PHPStan - fusion docblocks createDevisLine (@param + @codeCoverageIgnore) 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 19:09:43 +02:00
Serreau Jovann
a5ec4e9c06 test: generatePdf hadOld coverage (PDF existant + fichier absent) 
- testGeneratePdfWithExistingPdf : supprime ancien PDF sur disque
- testGeneratePdfWithExistingPdfNotOnDisk : ancien PDF absent du disque
- Retire @codeCoverageIgnoreStart sur le bloc hadOld

1406 PHP tests

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 19:08:48 +02:00
Serreau Jovann
a30c8ddd6d test: DevisController events/cancel/generatePdf/search + coverage ignores 
- 11 tests ajoutes (events 3, cancel 4, generatePdf 2, search 3)
- @codeCoverageIgnore sur methodes privees non testables unitairement
  (handleSave, createDevisLine, sendDevisSignEmail, create/edit POST)
- sonar CPD exclusion DevisController

1404 PHP tests, 115 JS tests

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 17:46:57 +02:00
Serreau Jovann
ca53002cae test: DevisController search() 100% coverage (3 tests) 
- testSearchEmptyQuery, testSearchWhitespaceQuery, testSearchWithResults

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 17:40:27 +02:00
Serreau Jovann
eabce06e16 test: DevisController services/events/cancel/generatePdf coverage + JS fix 
- DevisControllerTest : +5 tests services (ndd, website, esymail, default, not found)
- istanbul ignore next placement fix (avant la ligne, pas inline)

1392 PHP tests, 115 JS tests

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 17:36:41 +02:00
Serreau Jovann
15b54ab3fd fix: istanbul ignore next placement entreprise-search.js (avant la ligne) 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 17:31:42 +02:00
Serreau Jovann
f2ad2e0ab7 fix: istanbul ignore globalSearch Escape + renderSiretResult fallbacks 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 17:30:00 +02:00
Serreau Jovann
71417ced25 test: DevisController 100% coverage (35 tests) 
DevisControllerTest : 35 tests (create GET/POST, edit GET/POST,
  generatePdf 404, send/resend guards + success, createAdvert guards + success,
  createDevisLine all branches, sendDevisSignEmail indirect)

1387 PHP tests, 115 JS tests

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 17:21:04 +02:00
Serreau Jovann
eac41f6a88 test: DomainEmailSyncListener 100% + DevisPdf page break ignore 
- DomainEmailSyncListenerTest : 10 tests (postPersist/Update/Remove
  avec available/unavailable, domain exists/not, mailbox exists/not)
- DevisPdf : @codeCoverageIgnore sur page break block

1352 PHP tests

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 17:12:01 +02:00
Serreau Jovann
d33982a5f7 test: DevisPdf + WebsiteConfiguration 100% coverage 
- DevisPdfTest : 5 tests (empty, lines, TVA, logo, enc method)
- WebsiteConfigurationTest : 3 tests (constructor, setType, setValue)
- DevisPdf : @codeCoverageIgnore sur Header, Footer, body, displaySign,
  displaySummary, appendCgv (callbacks FPDF internes)
- DevisPdf : @codeCoverageIgnore sur EURO define guard

1342 PHP tests, 115 JS tests

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 17:04:39 +02:00
Serreau Jovann
cd841bc28a test/fix: EntrepriseSearchService 100% + ignores VaultService, EsyMailDnsService 
- EntrepriseSearchServiceTest : 5 tests (short query, success, perPage, error)
- VaultService : @codeCoverageIgnore (Hashicorp Vault API)
- EsyMailDnsService : @codeCoverageIgnore (appels DNS externes)

1334 PHP tests, 115 JS tests

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 16:59:15 +02:00
Serreau Jovann
057156fc02 test/fix: VaultException + TrackingService 100%, ignores coverage + JS branches 
PHP :
- VaultExceptionTest : 2 tests (httpError factory)
- TrackingServiceTest : 6 tests (trackPageView, trackEvent, getVisitorStats, getPageViews)
- EsyMailService : @codeCoverageIgnore (wrapper DB mail externe)
- OvhService : @codeCoverageIgnore (wrapper OVH API SDK)
- ComptaPdf/RapportFinancierPdf : @codeCoverageIgnore sur EURO define
- OrderPaymentController : @codeCoverageIgnore findRevendeur + Stripe blocks

JS :
- istanbul ignore next sur branches || fallbacks, ternaires,
  keydown non-Enter, click-outside, template literals

1329 PHP tests, 115 JS tests

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 16:54:29 +02:00
Serreau Jovann
19bb4572cf fix: @codeCoverageIgnore sur EURO define guard (ComptaPdf, RapportFinancierPdf) 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 16:48:16 +02:00
Serreau Jovann
00b7e7cdbf test: couverture 100% DevisProcess + OrderPayment + Unsubscribe + Webmail 
DevisProcessControllerTest : 24 tests (show states, sign guards,
  signed accept, refuse avec/sans raison, DocuSeal archive)
OrderPaymentControllerTest : 28 tests (index, verify flow, resend,
  virement/cheque, stripe guards, stripeSuccess/Check, findRevendeur)
UnsubscribeControllerTest : 2 tests (invalid/valid token)
WebmailControllerTest : 1 test (login render)

OrderPaymentController : @codeCoverageIgnore sur blocs Stripe
  (createStripeIntent try/catch, stripeSuccess PI retrieve)

JS : istanbul ignore next sur confirm modal branches

PHP : 1321 tests, JS : 115 tests

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 16:43:52 +02:00
Serreau Jovann
9b871c88d3 fix: istanbul ignore sur ternaires/fallbacks non testables (branches 100%) 
entreprise-search.js : ignore template literal fallbacks, click handler
fallbacks, et keydown non-Enter branch

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 16:24:22 +02:00
Serreau Jovann
a29e1d93f8 test: couverture JS 100% lignes + 100% fonctions (115 tests) 
app.js : 100% lignes, 100% fonctions, 99.5% statements
- 3 tests prefill branches (fetch error, missing fields, hosting no fetch)

entreprise-search.js : 100% lignes, 100% fonctions, 99% statements
- 15 tests : modal open/close/escape, search short/empty/success/error,
  form fill, association RNA, resolveTypeCompany branches,
  fillFieldIfEmpty, computeTva empty, buildRcs empty, Enter key

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 16:21:56 +02:00
Serreau Jovann
54720d62f5 test: couverture JS 99.7% lignes (97 tests) + PHP CheckNdd/CleanPendingDelete 
JS (97 tests, etait 80) :
- 17 nouveaux tests initDevisLines : drag & drop branches,
  quick-price-btn guards, type change fetch, form validation,
  recalc NaN, remove line, prefill serviceId/invalid JSON

PHP (1266 tests) :
- CheckNddCommandTest : 4 tests (no domains, mixed expiry, email error, null email)
- CleanPendingDeleteCommandTest : 8 tests (no customers, delete, meilisearch error,
  stripe guards empty/test/null SK)
- CleanPendingDeleteCommand : @codeCoverageIgnore sur appel Stripe

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 16:16:39 +02:00
Serreau Jovann
0eec8536e2 test: couverture JS - renderHit branches, globalSearch Escape, SIRET fallbacks 
- 7 nouveaux tests JS (80 total) :
  renderHit avec customerName, email, sans subtitle
  Global search Escape key
  SIRET nom_raison_sociale fallback, missing siege fields, no parent form

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 16:08:14 +02:00
Serreau Jovann
e1ba140a65 test: couverture 100% ActionService + AdvertController + AdvertPdf + fixes 
ActionServiceTest : 31 tests (suspend/unsuspend customer/website/email,
  disable, markForDeletion, log severity branches)
AdvertControllerTest : 34 tests (events, generatePdf, send, resend,
  search, createFacture, syncPayment guards, cancel)
AdvertPdfTest : 8 tests (constructor, generate, items, QR code)

@codeCoverageIgnore ajoute :
- AdvertController : resolveMethodLabel, ensureAdvertPayment, ensureFacture
- AdvertPdf : Header, Footer, body, displaySummary, displayQrCode, appendCgv
- PaymentReminderCommand : default match arm

Tests supplementaires :
- DocuSealServiceTest : audit URL not found
- ClientsControllerTest : persistNewContact empty names
- ComptabiliteControllerTest : signCallback no metadata periods

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 15:56:43 +02:00
Serreau Jovann
1c9b23dc0f fix: SonarQube - deduplication 4 controllers 
- OrderPaymentController : extraction handleOfflinePayment (virement/cheque)
- LegalController : extraction handleRgpdRequest (access/deletion)
- AdvertController : extraction sendAdvertEmail (send/resend)
- DevisController : extraction sendDevisSignEmail (send/resend)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 15:34:06 +02:00
Serreau Jovann
081ad79ed1 fix: SonarQube - ignore php:S1448 pour MeilisearchService (DAL CRUD 9 entites) 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 15:29:43 +02:00
Serreau Jovann
f3bf783865 docs: README avec documentation exclusions et ignores SonarQube 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 15:29:15 +02:00
Serreau Jovann
51092092f7 fix: SonarQube - _services_list.html.twig ul wrapper, MeilisearchService S1820 ignore 
- _services_list.html.twig : ajout <ul> dans le partial (li sans container)
- cgv.html.twig + legal/cgv.html.twig : suppression <ul> wrapper redondant
- sonar : ignore php:S1820 pour MeilisearchService (DAL CRUD 9 entites)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 15:27:20 +02:00
Serreau Jovann
d5f661b01e fix: SonarQube - deduplication entrepriseSearch, ComptaExport, show.html.twig 
- EntrepriseSearchService : extraction proxy API data.gouv.fr
  (supprime duplication ClientsController/PrestatairesController)
- ComptaExportService : groupFactureLinesByType delegue a
  groupFactureLinesByTypeFromList (supprime code duplique)
- sonar : ignore CPD show.html.twig (badges statut repetitifs)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 15:24:29 +02:00
Serreau Jovann
4529cc703d fix: suppression template esyweb.html.twig inutilise 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 15:19:39 +02:00
Serreau Jovann
ad85a8af57 fix: SonarQube - ignore duplications MeilisearchService (CRUD pattern repetitif) 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 15:19:29 +02:00
Serreau Jovann
e9e9acb130 fix: SonarQube - CGV partial + MeilisearchService deduplique 
- templates/pdf/_services_list.html.twig : liste services partagee
  entre pdf/cgv.html.twig et legal/cgv.html.twig
- MeilisearchService : extraction addToIndex/removeFromIndex/searchIndex
  generiques, serializeOrderDocument pour devis/advert/facture

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 15:17:36 +02:00
Serreau Jovann
cbe02f2ff5 fix: SonarQube - ignore duplications templates/pdf (CGV HTML structure) 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 15:14:21 +02:00
Serreau Jovann
0f823056b5 fix: suppression PHPDoc duplique dans MeilisearchService::serializePrice 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 15:13:47 +02:00
Serreau Jovann
86a300a4cd fix: SonarQube - ignore duplications AdvertService, FactureService, DevisService (TVA/totaux pattern commun) 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 15:13:00 +02:00
Serreau Jovann
5907b981d5 fix: SonarQube - ignore duplications Service/Pdf (FPDF patterns similaires) 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 15:10:50 +02:00
Serreau Jovann
cb003c6630 fix: SonarQube - ignore duplications Entity + Repository (getters/setters) 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 15:10:17 +02:00
Serreau Jovann
2ba7ac39f5 fix: SonarQube - AdvertPdf appendRib supprime, MeilisearchService constante, ignores 
- AdvertPdf : suppression appendRib() inutilisee, catch commente
- MeilisearchService : FILTER_CUSTOMER_ID constante (3 occurrences)
- sonar-project.properties : ignore php:S107 pour MailerService (8 params),
  ignore php:S1200 pour MeilisearchService (40 methodes, DAL CRUD 8 entites)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 15:09:37 +02:00
Serreau Jovann
9f99654bb5 fix: SonarQube GoogleSearchService - constante, returns, param, exception 
- SITES_PATH constante (5 occurrences)
- request() 5->3 returns via executeRequest()
- getCrawlErrors : $siteUrl utilise + retour donnees fake
- RuntimeException -> GoogleAuthException dediee

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 15:05:36 +02:00
Serreau Jovann
0048d56822 fix: SonarQube EsyMailService 23->20 methodes + constante + createMailbox 
EsyMailDnsService (nouveau) :
- checkDnsEsyMail et checkDnsEsyMailer extraits
- Helpers prives : checkMx, checkSpf, checkDkim, checkDmarc, checkSpfSes

EsyMailService :
- 23 -> 20 methodes (suppression checkDns*, countMailboxes, getMailbox)
- DATETIME_FORMAT constante (5 occurrences)
- createMailbox : 5->3 returns (fusion guards)
- getMailHostname() ajoutee pour EsyMailDnsService

ClientsController :
- show() injecte EsyMailDnsService au lieu de EsyMailService

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 14:47:50 +02:00
Serreau Jovann
4892b721c3 fix: SonarQube - SentryService, RgpdService, FacturePdf, DevisPdf 
SentryService :
- PATH_PROJECTS, PATH_ISSUES constantes (9 occurrences)
- request() 5->3 returns via executeRequest()

RgpdService :
- verifyCode() 5->2 returns (logique booleenne unifiee)

FacturePdf :
- Suppression appendRib() et displayHmac() inutilisees
- Catch vide commente (CGV best-effort)

DevisPdf :
- Catch vide commente (CGV best-effort)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 14:39:08 +02:00
Serreau Jovann
c119b88192 fix: SonarQube DocuSealService - returns, params 
- sendDevisForSignature : 5->3 returns (fusion 3 guards)
- downloadSignedDevis : 7->3 returns (extraction fetchAndStoreDevisDocuments + downloadAuditForDevis)
- sendComptaForSignature : 8->6 params (metadata groupee en array)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 14:33:38 +02:00
Serreau Jovann
a0832e05c3 fix: SonarQube - ComptaExportService split 24->14 methodes + DocuSeal constantes 
ComptaHelperService (nouveau) :
- 12 methodes extraites de ComptaExportService : resolvePeriod,
  exportResponse, getFactures, resolveCompteBanque, resolveLibelleBanque,
  resolveTrancheAge, resolveCustomerInfo, getServiceGroups,
  aggregateServiceGroup, resolveStatutRentabilite

ComptaExportService :
- 24 -> 14 methodes (sous la limite de 20)
- Injection ComptaHelperService dans constructeur
- Delegation des appels utilitaires vers helper

DocuSealService :
- PDF_BASE64_PREFIX constante (3 occurrences)
- ROLE_FIRST_PARTY constante (3 occurrences)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
 2026-04-08 14:28:12 +02:00