admin/crm_ecosplay
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: SonarQube - AdvertPdf appendRib supprime, MeilisearchService constante, ignores

Browse Source 
- AdvertPdf : suppression appendRib() inutilisee, catch commente
- MeilisearchService : FILTER_CUSTOMER_ID constante (3 occurrences)
- sonar-project.properties : ignore php:S107 pour MailerService (8 params),
  ignore php:S1200 pour MeilisearchService (40 methodes, DAL CRUD 8 entites)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Serreau Jovann
2026-04-08 15:09:37 +02:00
parent 9f99654bb5
commit 2ba7ac39f5
3 changed files with 11 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
sonar-project.properties
View File

@@ -20,9 +20,13 @@ sonar.php.tests.reportPath=var/reports/phpunit.xml
sonar.cpd.exclusions=migrations/**,src/Service/TarificationService.php
# Global rule ignores
sonar.issue.ignore.multicriteria=e1
sonar.issue.ignore.multicriteria=e1,e2,e3
sonar.issue.ignore.multicriteria.e1.ruleKey=php:S4144
sonar.issue.ignore.multicriteria.e1.resourceKey=**/*.php
sonar.issue.ignore.multicriteria.e2.ruleKey=php:S107
sonar.issue.ignore.multicriteria.e2.resourceKey=src/Service/MailerService.php
sonar.issue.ignore.multicriteria.e3.ruleKey=php:S1200
sonar.issue.ignore.multicriteria.e3.resourceKey=src/Service/MeilisearchService.php
# ─── Rapports externes ────────────────────────────
sonar.php.phpstan.reportPaths=var/reports/phpstan-report.json

8
src/Service/MeilisearchService.php
View File

@@ -17,6 +17,8 @@ use Symfony\Component\DependencyInjection\Attribute\Autowire;
class MeilisearchService
{
private const FILTER_CUSTOMER_ID = 'customerId = ';
private Client $client;
public function __construct(
@@ -255,7 +257,7 @@ class MeilisearchService
try {
$options = ['limit' => $limit];
if (null !== $customerId) {
$options['filter'] = 'customerId = '.$customerId;
$options['filter'] = self::FILTER_CUSTOMER_ID.$customerId;
}
return $this->client->index('customer_devis')->search($query, $options)->getHits();
@@ -290,7 +292,7 @@ class MeilisearchService
try {
$options = ['limit' => $limit];
if (null !== $customerId) {
$options['filter'] = 'customerId = '.$customerId;
$options['filter'] = self::FILTER_CUSTOMER_ID.$customerId;
}
return $this->client->index('customer_advert')->search($query, $options)->getHits();
@@ -325,7 +327,7 @@ class MeilisearchService
try {
$options = ['limit' => $limit];
if (null !== $customerId) {
$options['filter'] = 'customerId = '.$customerId;
$options['filter'] = self::FILTER_CUSTOMER_ID.$customerId;
}
return $this->client->index('customer_facture')->search($query, $options)->getHits();

24
src/Service/Pdf/AdvertPdf.php
View File

@@ -197,29 +197,7 @@ class AdvertPdf extends Fpdi
@unlink($tmpCgv);
} catch (\Throwable) {
}
}
/** @phpstan-ignore-next-line */
private function appendRib(): void
{
$ribPath = $this->kernel->getProjectDir().'/public/rib.pdf';
if (!file_exists($ribPath)) {
return;
}
try {
$this->lastAdvertPage = $this->PageNo();
$this->skipHeaderFooter = true;
$pageCount = $this->setSourceFile($ribPath);
for ($i = 1; $i <= $pageCount; ++$i) {
$tpl = $this->importPage($i);
$size = $this->getTemplateSize($tpl);
$this->AddPage($size['orientation'] ?? 'P', [$size['width'], $size['height']]);
$this->useTemplate($tpl);
}
} catch (\Throwable) {
// CGV generation is best-effort
}
}