admin/crm_ecosplay
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: SonarQube - variables/params inutilises, returns

Browse Source 
- DevisProcessController : suppression $submitter inutilisee
- OrderPaymentController : suppression param $numOrder inutilise
- WebhookStripeController : checkPaymentPreConditions 4->3 returns
- DomainEmailSyncListener : $event -> $_event (requis par Doctrine)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Serreau Jovann
2026-04-08 13:54:13 +02:00
parent 799af4c551
commit f558653181
4 changed files with 9 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/Controller/DevisProcessController.php
View File

@@ -102,7 +102,6 @@ class DevisProcessController extends AbstractController
$submitterId = (int) ($devis->getSubmissionId() ?? '0');
if ($submitterId > 0) {
try {
$submitter = $this->docuSeal->getSubmitterSlug($submitterId);
// Recupere le submission_id via l'API pour archiver
$submitterData = $this->docuSeal->getSubmitterData($submitterId);
if (null !== $submitterData) {

3
src/Controller/OrderPaymentController.php
View File

@@ -74,7 +74,7 @@ class OrderPaymentController extends AbstractController
}
$error = ('POST' === $request->getMethod())
? $this->handleVerifyPost($request, $advert, $session, $sessionKey, $numOrder)
? $this->handleVerifyPost($request, $advert, $session, $sessionKey)
: null;
// Redirect si POST a valide le code
@@ -100,7 +100,6 @@ class OrderPaymentController extends AbstractController
Advert $advert,
\Symfony\Component\HttpFoundation\Session\SessionInterface $session,
string $sessionKey,
string $numOrder,
): string|true {
$codeKey = 'order_code_'.$advert->getId();
$codeExpiresKey = 'order_code_expires_'.$advert->getId();

14
src/Controller/WebhookStripeController.php
View File

@@ -214,16 +214,12 @@ class WebhookStripeController extends AbstractController
*/
private function checkPaymentPreConditions(?Advert $advert, ?string $advertId, object $paymentIntent, string $channel, array $metadata): ?JsonResponse
{
if (null === $advertId) {
$this->logger->info(self::LOG_PI_SUCCEEDED.$channel.']: pas de advert_id dans metadata', ['metadata' => $metadata]);
if (null === $advertId || null === $advert) {
$action = null === $advertId ? 'no_advert' : 'advert_not_found';
$logMethod = null === $advertId ? 'info' : 'warning';
$this->logger->$logMethod(self::LOG_PI_SUCCEEDED.$channel.']: '.(null === $advertId ? 'pas de advert_id dans metadata' : 'advert introuvable'), null === $advertId ? ['metadata' => $metadata] : ['advert_id' => $advertId]);
return new JsonResponse(['status' => 'ok', 'action' => 'no_advert']);
}
if (null === $advert) {
$this->logger->warning(self::LOG_PI_SUCCEEDED.$channel.']: advert introuvable', ['advert_id' => $advertId]);
return new JsonResponse(['status' => 'ok', 'action' => 'advert_not_found']);
return new JsonResponse(['status' => 'ok', 'action' => $action]);
}
if (Advert::STATE_ACCEPTED === $advert->getState() && $advert->getStripePaymentId() === $paymentIntent->id) {

6
src/EventListener/DomainEmailSyncListener.php
View File

@@ -22,7 +22,7 @@ class DomainEmailSyncListener
) {
}
public function postPersist(DomainEmail $email, PostPersistEventArgs $event): void
public function postPersist(DomainEmail $email, PostPersistEventArgs $_event): void
{
if (!$this->esyMail->isAvailable()) {
return;
@@ -42,7 +42,7 @@ class DomainEmailSyncListener
}
}
public function postUpdate(DomainEmail $email, PostUpdateEventArgs $event): void
public function postUpdate(DomainEmail $email, PostUpdateEventArgs $_event): void
{
if (!$this->esyMail->isAvailable()) {
return;
@@ -58,7 +58,7 @@ class DomainEmailSyncListener
$this->logger->info('EsyMail sync: boite mise a jour '.$fullEmail);
}
public function postRemove(DomainEmail $email, PostRemoveEventArgs $event): void
public function postRemove(DomainEmail $email, PostRemoveEventArgs $_event): void
{
if (!$this->esyMail->isAvailable()) {
return;