admin/crm_ecosplay
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: KeycloakAdminService - constante PATH_GROUPS, fusion if imbriqués

Browse Source 
- Ajout constante PATH_GROUPS = '/groups' (remplace 4 littéraux dupliqués)
- Fusion des 2 if imbriqués dans ensureRequiredGroups en une seule condition
  avec && (in_array + createGroup)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Serreau Jovann
2026-04-03 11:14:47 +02:00
parent bbf43baf5c
commit de9205ae14
1 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/Service/KeycloakAdminService.php
View File

@@ -8,6 +8,7 @@ use Symfony\Contracts\HttpClient\HttpClientInterface;
class KeycloakAdminService
{
private const PATH_USERS = '/users';
private const PATH_GROUPS = '/groups';
private const AUTH_BEARER = 'Bearer ';
/** Groupes requis pour le CRM SITECONSEIL */
@@ -53,10 +54,8 @@ class KeycloakAdminService
$created = [];
foreach (self::REQUIRED_GROUPS as $groupName) {
if (!\in_array($groupName, $existingNames, true)) {
if ($this->createGroup($groupName)) {
$created[] = $groupName;
}
if (!\in_array($groupName, $existingNames, true) && $this->createGroup($groupName)) {
$created[] = $groupName;
}
}
@@ -69,7 +68,7 @@ class KeycloakAdminService
public function createGroup(string $groupName): bool
{
$token = $this->getToken();
$response = $this->httpClient->request('POST', $this->getAdminUrl('/groups'), [
$response = $this->httpClient->request('POST', $this->getAdminUrl(self::PATH_GROUPS), [
'headers' => ['Authorization' => self::AUTH_BEARER.$token],
'json' => ['name' => $groupName],
]);
@@ -267,7 +266,7 @@ class KeycloakAdminService
public function listGroups(): array
{
$token = $this->getToken();
$response = $this->httpClient->request('GET', $this->getAdminUrl('/groups'), [
$response = $this->httpClient->request('GET', $this->getAdminUrl(self::PATH_GROUPS), [
'headers' => ['Authorization' => self::AUTH_BEARER.$token],
]);
@@ -285,7 +284,7 @@ class KeycloakAdminService
private function getGroupIdByName(string $groupName): ?string
{
$token = $this->getToken();
$response = $this->httpClient->request('GET', $this->getAdminUrl('/groups'), [
$response = $this->httpClient->request('GET', $this->getAdminUrl(self::PATH_GROUPS), [
'headers' => ['Authorization' => self::AUTH_BEARER.$token],
'query' => ['search' => $groupName, 'exact' => 'true'],
]);