Files
e-ticket/tests/EventSubscriber/SubAccountPermissionSubscriberTest.php
Serreau Jovann 04927ec988 Complete TASK_CHECKUP: security, UX, tests, coverage, accessibility, config externalization
Billetterie:
- Partial refund support (STATUS_PARTIALLY_REFUNDED, refundedAmount field, migration)
- Race condition fix: PESSIMISTIC_WRITE lock on stock decrement in transaction
- Idempotency key on PaymentIntent::create, reuse existing PI if stripeSessionId set
- Disable checkout when event ended (server 400 + template hide)
- Webhook deduplication via cache (24h TTL on stripe event.id)
- Email validation (filter_var) in OrderController guest flow
- JSON cart validation (structure check before processing)
- Invitation expiration after 7 days (isExpired method + landing page message)
- Stripe Checkout fallback when JS fails to load (noscript + redirect)

Config externalization:
- Move Stripe fees (STRIPE_FEE_RATE, STRIPE_FEE_FIXED) and admin email (ADMIN_EMAIL) to .env/services.yaml
- Replace all hardcoded contact@e-cosplay.fr across 13 files
- MailerService: getAdminEmail()/getAdminFrom(), default $from=null resolves to admin

UX & Accessibility:
- ARIA tabs: role=tablist/tab/tabpanel, aria-selected, keyboard nav (arrows, Home, End)
- aria-label on cart +/- buttons and editor toolbar buttons
- tabindex=0 on editor toolbar buttons for keyboard access
- data-confirm handler in app.js (was only in admin.js)
- Cart error feedback on checkout failure
- Billet designer save feedback (loading/success/error states)
- Stock polling every 30s with rupture/low stock badges
- Back to event link on payment page

Security:
- HTML sanitizer: BLOCKED_TAGS list (script, style, iframe, svg, etc.) - content fully removed
- Stripe polling timeout (15s max) with fallback redirect
- Rate limiting on public order access (20/5min)
- .catch() on all fetch() calls (sortable, billet-designer)

Tests (92% PHP, 100% JS lines):
- PCOV added to dev Dockerfile
- Test DB setup: .env.test with DATABASE_URL, Redis auth, Meilisearch key
- Rate limiter disabled in test env
- Makefile: test_db_setup, test_db_reset, run_test_php, run_test_coverage_php/js
- New tests: InvitationFlowTest (21), AuditServiceTest (4), ExportServiceTest (9), InvoiceServiceTest (4)
- New tests: SuspendedUserSubscriberTest, RateLimiterSubscriberTest, MeilisearchServiceTest
- New tests: Stripe webhook payment_failed (6) + charge.refunded (6)
- New tests: BilletBuyer refund, User suspended, OrganizerInvitation expiration
- JS tests: stock polling (6), data-confirm (2), copy-url restore (1), editor ARIA (2), XSS (9), tabs keyboard (9)
- ESLint + PHP CS Fixer: 0 errors
- SonarQube exclusions aligned with vitest coverage config

Infra:
- Meilisearch consistency command (app:meilisearch:check-consistency --fix) + cron daily 3am
- MeilisearchService: getAllDocumentIds(), listIndexes()

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-23 11:14:06 +01:00

155 lines
5.7 KiB
PHP

<?php
namespace App\Tests\EventSubscriber;
use App\Entity\User;
use App\EventSubscriber\SubAccountPermissionSubscriber;
use PHPUnit\Framework\TestCase;
use Symfony\Bundle\SecurityBundle\Security;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Session\Session;
use Symfony\Component\HttpFoundation\Session\Storage\MockArraySessionStorage;
use Symfony\Component\HttpKernel\Event\RequestEvent;
use Symfony\Component\HttpKernel\HttpKernelInterface;
use Symfony\Component\HttpKernel\KernelEvents;
use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
class SubAccountPermissionSubscriberTest extends TestCase
{
public function testSubscribedEvents(): void
{
self::assertArrayHasKey(KernelEvents::REQUEST, SubAccountPermissionSubscriber::getSubscribedEvents());
}
public function testIgnoresNonSubAccount(): void
{
$user = new User();
$user->setEmail('orga@test.fr');
$user->setFirstName('O');
$user->setLastName('T');
$user->setPassword('h');
$security = $this->createMock(Security::class);
$security->method('getUser')->willReturn($user);
$urlGenerator = $this->createMock(UrlGeneratorInterface::class);
$subscriber = new SubAccountPermissionSubscriber($security, $urlGenerator);
$request = Request::create('/mon-compte/evenement/creer', 'GET');
$request->attributes->set('_route', 'app_account_create_event');
$request->setSession(new Session(new MockArraySessionStorage()));
$kernel = $this->createMock(HttpKernelInterface::class);
$event = new RequestEvent($kernel, $request, HttpKernelInterface::MAIN_REQUEST);
$subscriber->onKernelRequest($event);
self::assertNull($event->getResponse());
}
public function testBlocksSubAccountWithoutEventsPermission(): void
{
$parent = new User();
$parent->setEmail('parent@test.fr');
$parent->setFirstName('P');
$parent->setLastName('T');
$parent->setPassword('h');
$sub = new User();
$sub->setEmail('sub@test.fr');
$sub->setFirstName('S');
$sub->setLastName('T');
$sub->setPassword('h');
$sub->setParentOrganizer($parent);
$sub->setSubAccountPermissions(['scanner']);
$security = $this->createMock(Security::class);
$security->method('getUser')->willReturn($sub);
$urlGenerator = $this->createMock(UrlGeneratorInterface::class);
$urlGenerator->method('generate')->willReturn('/mon-compte');
$subscriber = new SubAccountPermissionSubscriber($security, $urlGenerator);
$request = Request::create('/mon-compte/evenement/creer', 'GET');
$request->attributes->set('_route', 'app_account_create_event');
$request->setSession(new Session(new MockArraySessionStorage()));
$kernel = $this->createMock(HttpKernelInterface::class);
$event = new RequestEvent($kernel, $request, HttpKernelInterface::MAIN_REQUEST);
$subscriber->onKernelRequest($event);
self::assertNotNull($event->getResponse());
self::assertSame(302, $event->getResponse()->getStatusCode());
}
public function testAllowsSubAccountWithEventsPermission(): void
{
$parent = new User();
$parent->setEmail('parent2@test.fr');
$parent->setFirstName('P');
$parent->setLastName('T');
$parent->setPassword('h');
$sub = new User();
$sub->setEmail('sub2@test.fr');
$sub->setFirstName('S');
$sub->setLastName('T');
$sub->setPassword('h');
$sub->setParentOrganizer($parent);
$sub->setSubAccountPermissions(['events', 'scanner']);
$security = $this->createMock(Security::class);
$security->method('getUser')->willReturn($sub);
$urlGenerator = $this->createMock(UrlGeneratorInterface::class);
$subscriber = new SubAccountPermissionSubscriber($security, $urlGenerator);
$request = Request::create('/mon-compte/evenement/creer', 'GET');
$request->attributes->set('_route', 'app_account_create_event');
$request->setSession(new Session(new MockArraySessionStorage()));
$kernel = $this->createMock(HttpKernelInterface::class);
$event = new RequestEvent($kernel, $request, HttpKernelInterface::MAIN_REQUEST);
$subscriber->onKernelRequest($event);
self::assertNull($event->getResponse());
}
public function testBlocksSubAccountWithoutTicketsPermission(): void
{
$parent = new User();
$parent->setEmail('parent3@test.fr');
$parent->setFirstName('P');
$parent->setLastName('T');
$parent->setPassword('h');
$sub = new User();
$sub->setEmail('sub3@test.fr');
$sub->setFirstName('S');
$sub->setLastName('T');
$sub->setPassword('h');
$sub->setParentOrganizer($parent);
$sub->setSubAccountPermissions(['events']);
$security = $this->createMock(Security::class);
$security->method('getUser')->willReturn($sub);
$urlGenerator = $this->createMock(UrlGeneratorInterface::class);
$urlGenerator->method('generate')->willReturn('/mon-compte');
$subscriber = new SubAccountPermissionSubscriber($security, $urlGenerator);
$request = Request::create('/mon-compte/evenement/1/billet/ajouter', 'GET');
$request->attributes->set('_route', 'app_account_event_add_billet');
$request->setSession(new Session(new MockArraySessionStorage()));
$kernel = $this->createMock(HttpKernelInterface::class);
$event = new RequestEvent($kernel, $request, HttpKernelInterface::MAIN_REQUEST);
$subscriber->onKernelRequest($event);
self::assertNotNull($event->getResponse());
}
}