Files
e-ticket/tests/Service/InvoiceServiceTest.php
Serreau Jovann 04927ec988 Complete TASK_CHECKUP: security, UX, tests, coverage, accessibility, config externalization
Billetterie:
- Partial refund support (STATUS_PARTIALLY_REFUNDED, refundedAmount field, migration)
- Race condition fix: PESSIMISTIC_WRITE lock on stock decrement in transaction
- Idempotency key on PaymentIntent::create, reuse existing PI if stripeSessionId set
- Disable checkout when event ended (server 400 + template hide)
- Webhook deduplication via cache (24h TTL on stripe event.id)
- Email validation (filter_var) in OrderController guest flow
- JSON cart validation (structure check before processing)
- Invitation expiration after 7 days (isExpired method + landing page message)
- Stripe Checkout fallback when JS fails to load (noscript + redirect)

Config externalization:
- Move Stripe fees (STRIPE_FEE_RATE, STRIPE_FEE_FIXED) and admin email (ADMIN_EMAIL) to .env/services.yaml
- Replace all hardcoded contact@e-cosplay.fr across 13 files
- MailerService: getAdminEmail()/getAdminFrom(), default $from=null resolves to admin

UX & Accessibility:
- ARIA tabs: role=tablist/tab/tabpanel, aria-selected, keyboard nav (arrows, Home, End)
- aria-label on cart +/- buttons and editor toolbar buttons
- tabindex=0 on editor toolbar buttons for keyboard access
- data-confirm handler in app.js (was only in admin.js)
- Cart error feedback on checkout failure
- Billet designer save feedback (loading/success/error states)
- Stock polling every 30s with rupture/low stock badges
- Back to event link on payment page

Security:
- HTML sanitizer: BLOCKED_TAGS list (script, style, iframe, svg, etc.) - content fully removed
- Stripe polling timeout (15s max) with fallback redirect
- Rate limiting on public order access (20/5min)
- .catch() on all fetch() calls (sortable, billet-designer)

Tests (92% PHP, 100% JS lines):
- PCOV added to dev Dockerfile
- Test DB setup: .env.test with DATABASE_URL, Redis auth, Meilisearch key
- Rate limiter disabled in test env
- Makefile: test_db_setup, test_db_reset, run_test_php, run_test_coverage_php/js
- New tests: InvitationFlowTest (21), AuditServiceTest (4), ExportServiceTest (9), InvoiceServiceTest (4)
- New tests: SuspendedUserSubscriberTest, RateLimiterSubscriberTest, MeilisearchServiceTest
- New tests: Stripe webhook payment_failed (6) + charge.refunded (6)
- New tests: BilletBuyer refund, User suspended, OrganizerInvitation expiration
- JS tests: stock polling (6), data-confirm (2), copy-url restore (1), editor ARIA (2), XSS (9), tabs keyboard (9)
- ESLint + PHP CS Fixer: 0 errors
- SonarQube exclusions aligned with vitest coverage config

Infra:
- Meilisearch consistency command (app:meilisearch:check-consistency --fix) + cron daily 3am
- MeilisearchService: getAllDocumentIds(), listIndexes()

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-23 11:14:06 +01:00

110 lines
3.5 KiB
PHP

<?php
namespace App\Tests\Service;
use App\Entity\BilletBuyer;
use App\Entity\Event;
use App\Entity\User;
use App\Service\InvoiceService;
use PHPUnit\Framework\TestCase;
use Twig\Environment;
class InvoiceServiceTest extends TestCase
{
private function createMockOrder(): BilletBuyer
{
$user = $this->createMock(User::class);
$user->method('getLogoName')->willReturn(null);
$event = $this->createMock(Event::class);
$event->method('getAccount')->willReturn($user);
$order = $this->createMock(BilletBuyer::class);
$order->method('getEvent')->willReturn($event);
$order->method('getOrderNumber')->willReturn('2026-03-15-1');
return $order;
}
public function testGeneratePdfReturnsPdfContent(): void
{
$twig = $this->createMock(Environment::class);
$twig->method('render')->with('pdf/invoice.html.twig', $this->anything())
->willReturn('<html><body><h1>Facture</h1></body></html>');
$service = new InvoiceService($twig, '/tmp/test-project');
$order = $this->createMockOrder();
$pdf = $service->generatePdf($order);
self::assertNotEmpty($pdf);
self::assertStringStartsWith('%PDF', $pdf);
}
public function testGeneratePdfPassesCorrectData(): void
{
$twig = $this->createMock(Environment::class);
$order = $this->createMockOrder();
$twig->expects($this->once())->method('render')->with(
'pdf/invoice.html.twig',
$this->callback(function (array $params) use ($order) {
return $params['order'] === $order
&& $params['organizer'] === $order->getEvent()->getAccount()
&& '' === $params['logoBase64'];
})
)->willReturn('<html><body>test</body></html>');
$service = new InvoiceService($twig, '/tmp/nonexistent-project');
$service->generatePdf($order);
}
public function testGenerateToFileCreatesFile(): void
{
$twig = $this->createMock(Environment::class);
$twig->method('render')->willReturn('<html><body>invoice</body></html>');
$tmpDir = sys_get_temp_dir().'/invoice-test-'.uniqid();
mkdir($tmpDir);
$service = new InvoiceService($twig, $tmpDir);
$order = $this->createMockOrder();
$path = $service->generateToFile($order);
self::assertFileExists($path);
self::assertStringStartsWith('%PDF', (string) file_get_contents($path));
self::assertStringContainsString('facture_2026-03-15-1.pdf', $path);
// Cleanup
unlink($path);
rmdir($tmpDir.'/var/invoices');
rmdir($tmpDir.'/var');
rmdir($tmpDir);
}
public function testGeneratePdfWithLogo(): void
{
$twig = $this->createMock(Environment::class);
$tmpDir = sys_get_temp_dir().'/invoice-logo-test-'.uniqid();
mkdir($tmpDir);
mkdir($tmpDir.'/public', 0o755, true);
file_put_contents($tmpDir.'/public/logo.png', 'fake-png-data');
$twig->expects($this->once())->method('render')->with(
'pdf/invoice.html.twig',
$this->callback(fn (array $params) => '' !== $params['logoBase64'] && str_starts_with($params['logoBase64'], 'data:'))
)->willReturn('<html><body>test</body></html>');
$service = new InvoiceService($twig, $tmpDir);
$order = $this->createMockOrder();
$service->generatePdf($order);
// Cleanup
unlink($tmpDir.'/public/logo.png');
rmdir($tmpDir.'/public');
rmdir($tmpDir);
}
}