From 4caff2e0320ca5ffefccdc8f4d40ad0b0de218f5 Mon Sep 17 00:00:00 2001 From: Serreau Jovann Date: Thu, 26 Mar 2026 16:16:36 +0100 Subject: [PATCH] Fix SonarQube warnings: reduce returns, extract constants, fix viewport - Reduce requireStripeReady() from 4 returns to 2 by combining conditions - Extract SCANNER_PATH constant in ScannerController to avoid duplicated "/scanner/" literal - Remove user-scalable=no from scanner viewport meta (WCAG accessibility) Co-Authored-By: Claude Opus 4.6 (1M context) --- src/Controller/AccountController.php | 11 +++-------- src/Controller/ScannerController.php | 6 ++++-- templates/scanner/index.html.twig | 2 +- 3 files changed, 8 insertions(+), 11 deletions(-) diff --git a/src/Controller/AccountController.php b/src/Controller/AccountController.php index 3a48309..a4093c4 100644 --- a/src/Controller/AccountController.php +++ b/src/Controller/AccountController.php @@ -1559,15 +1559,10 @@ class AccountController extends AbstractController /** @var User $user */ $user = $this->getUser(); - if (!$user->isStripeChargesEnabled() || !$user->isStripePayoutsEnabled()) { - return $this->redirectToRoute('app_account'); - } + $stripeNotReady = !$user->isStripeChargesEnabled() || !$user->isStripePayoutsEnabled(); + $billingBlocked = $user->isBilling() && 'good' !== $user->getBillingState(); - if ($user->isBilling() && 'good' !== $user->getBillingState()) { - return $this->redirectToRoute('app_account'); - } - - return null; + return ($stripeNotReady || $billingBlocked) ? $this->redirectToRoute('app_account') : null; } /** diff --git a/src/Controller/ScannerController.php b/src/Controller/ScannerController.php index c9129fb..77da408 100644 --- a/src/Controller/ScannerController.php +++ b/src/Controller/ScannerController.php @@ -8,6 +8,8 @@ use Symfony\Component\Routing\Attribute\Route; class ScannerController extends AbstractController { + private const SCANNER_PATH = '/scanner/'; + #[Route('/scanner/', name: 'app_scanner', methods: ['GET'])] public function index(): Response { @@ -21,8 +23,8 @@ class ScannerController extends AbstractController 'name' => 'E-Ticket Scanner', 'short_name' => 'Scanner', 'description' => 'Application de scan de billets pour organisateurs', - 'start_url' => '/scanner/', - 'scope' => '/scanner/', + 'start_url' => self::SCANNER_PATH, + 'scope' => self::SCANNER_PATH, 'display' => 'standalone', 'orientation' => 'portrait', 'theme_color' => '#111827', diff --git a/templates/scanner/index.html.twig b/templates/scanner/index.html.twig index 1684e6b..72dc9b3 100644 --- a/templates/scanner/index.html.twig +++ b/templates/scanner/index.html.twig @@ -2,7 +2,7 @@ - + E-Ticket Scanner