Complete TASK_CHECKUP: security, UX, tests, coverage, accessibility, config externalization
Billetterie: - Partial refund support (STATUS_PARTIALLY_REFUNDED, refundedAmount field, migration) - Race condition fix: PESSIMISTIC_WRITE lock on stock decrement in transaction - Idempotency key on PaymentIntent::create, reuse existing PI if stripeSessionId set - Disable checkout when event ended (server 400 + template hide) - Webhook deduplication via cache (24h TTL on stripe event.id) - Email validation (filter_var) in OrderController guest flow - JSON cart validation (structure check before processing) - Invitation expiration after 7 days (isExpired method + landing page message) - Stripe Checkout fallback when JS fails to load (noscript + redirect) Config externalization: - Move Stripe fees (STRIPE_FEE_RATE, STRIPE_FEE_FIXED) and admin email (ADMIN_EMAIL) to .env/services.yaml - Replace all hardcoded contact@e-cosplay.fr across 13 files - MailerService: getAdminEmail()/getAdminFrom(), default $from=null resolves to admin UX & Accessibility: - ARIA tabs: role=tablist/tab/tabpanel, aria-selected, keyboard nav (arrows, Home, End) - aria-label on cart +/- buttons and editor toolbar buttons - tabindex=0 on editor toolbar buttons for keyboard access - data-confirm handler in app.js (was only in admin.js) - Cart error feedback on checkout failure - Billet designer save feedback (loading/success/error states) - Stock polling every 30s with rupture/low stock badges - Back to event link on payment page Security: - HTML sanitizer: BLOCKED_TAGS list (script, style, iframe, svg, etc.) - content fully removed - Stripe polling timeout (15s max) with fallback redirect - Rate limiting on public order access (20/5min) - .catch() on all fetch() calls (sortable, billet-designer) Tests (92% PHP, 100% JS lines): - PCOV added to dev Dockerfile - Test DB setup: .env.test with DATABASE_URL, Redis auth, Meilisearch key - Rate limiter disabled in test env - Makefile: test_db_setup, test_db_reset, run_test_php, run_test_coverage_php/js - New tests: InvitationFlowTest (21), AuditServiceTest (4), ExportServiceTest (9), InvoiceServiceTest (4) - New tests: SuspendedUserSubscriberTest, RateLimiterSubscriberTest, MeilisearchServiceTest - New tests: Stripe webhook payment_failed (6) + charge.refunded (6) - New tests: BilletBuyer refund, User suspended, OrganizerInvitation expiration - JS tests: stock polling (6), data-confirm (2), copy-url restore (1), editor ARIA (2), XSS (9), tabs keyboard (9) - ESLint + PHP CS Fixer: 0 errors - SonarQube exclusions aligned with vitest coverage config Infra: - Meilisearch consistency command (app:meilisearch:check-consistency --fix) + cron daily 3am - MeilisearchService: getAllDocumentIds(), listIndexes() Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -174,4 +174,30 @@ class BilletBuyerTest extends TestCase
|
||||
|
||||
self::assertNotSame($b1->getReference(), $b2->getReference());
|
||||
}
|
||||
|
||||
public function testRefundedAmountDefaults(): void
|
||||
{
|
||||
$buyer = new BilletBuyer();
|
||||
|
||||
self::assertSame(0, $buyer->getRefundedAmount());
|
||||
self::assertSame(0.0, $buyer->getRefundedAmountDecimal());
|
||||
}
|
||||
|
||||
public function testSetAndGetRefundedAmount(): void
|
||||
{
|
||||
$buyer = new BilletBuyer();
|
||||
$result = $buyer->setRefundedAmount(1500);
|
||||
|
||||
self::assertSame(1500, $buyer->getRefundedAmount());
|
||||
self::assertSame(15.0, $buyer->getRefundedAmountDecimal());
|
||||
self::assertSame($buyer, $result);
|
||||
}
|
||||
|
||||
public function testStatusPartiallyRefunded(): void
|
||||
{
|
||||
$buyer = new BilletBuyer();
|
||||
$buyer->setStatus(BilletBuyer::STATUS_PARTIALLY_REFUNDED);
|
||||
|
||||
self::assertSame('partially_refunded', $buyer->getStatus());
|
||||
}
|
||||
}
|
||||
|
||||
@@ -102,4 +102,49 @@ class OrganizerInvitationTest extends TestCase
|
||||
|
||||
self::assertNotSame($inv1->getToken(), $inv2->getToken());
|
||||
}
|
||||
|
||||
public function testIsExpiredFreshInvitation(): void
|
||||
{
|
||||
$inv = new OrganizerInvitation();
|
||||
self::assertFalse($inv->isExpired());
|
||||
}
|
||||
|
||||
public function testIsExpiredOldInvitation(): void
|
||||
{
|
||||
$inv = new OrganizerInvitation();
|
||||
$ref = new \ReflectionProperty($inv, 'createdAt');
|
||||
$ref->setValue($inv, new \DateTimeImmutable('-8 days'));
|
||||
|
||||
self::assertTrue($inv->isExpired());
|
||||
}
|
||||
|
||||
public function testIsExpiredAcceptedNeverExpires(): void
|
||||
{
|
||||
$inv = new OrganizerInvitation();
|
||||
$ref = new \ReflectionProperty($inv, 'createdAt');
|
||||
$ref->setValue($inv, new \DateTimeImmutable('-30 days'));
|
||||
$inv->setStatus(OrganizerInvitation::STATUS_ACCEPTED);
|
||||
|
||||
self::assertFalse($inv->isExpired());
|
||||
}
|
||||
|
||||
public function testIsExpiredRefusedNeverExpires(): void
|
||||
{
|
||||
$inv = new OrganizerInvitation();
|
||||
$ref = new \ReflectionProperty($inv, 'createdAt');
|
||||
$ref->setValue($inv, new \DateTimeImmutable('-30 days'));
|
||||
$inv->setStatus(OrganizerInvitation::STATUS_REFUSED);
|
||||
|
||||
self::assertFalse($inv->isExpired());
|
||||
}
|
||||
|
||||
public function testIsExpiredCustomDays(): void
|
||||
{
|
||||
$inv = new OrganizerInvitation();
|
||||
$ref = new \ReflectionProperty($inv, 'createdAt');
|
||||
$ref->setValue($inv, new \DateTimeImmutable('-4 days'));
|
||||
|
||||
self::assertFalse($inv->isExpired(7));
|
||||
self::assertTrue($inv->isExpired(3));
|
||||
}
|
||||
}
|
||||
|
||||
@@ -213,4 +213,21 @@ class UserTest extends TestCase
|
||||
|
||||
self::assertNull($user->getId());
|
||||
}
|
||||
|
||||
public function testSuspendedFields(): void
|
||||
{
|
||||
$user = new User();
|
||||
|
||||
self::assertNull($user->isSuspended());
|
||||
|
||||
$result = $user->setIsSuspended(true);
|
||||
self::assertSame($user, $result);
|
||||
self::assertTrue($user->isSuspended());
|
||||
|
||||
$user->setIsSuspended(false);
|
||||
self::assertFalse($user->isSuspended());
|
||||
|
||||
$user->setIsSuspended(null);
|
||||
self::assertNull($user->isSuspended());
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user