Complete TASK_CHECKUP: security, UX, tests, coverage, accessibility, config externalization
Billetterie: - Partial refund support (STATUS_PARTIALLY_REFUNDED, refundedAmount field, migration) - Race condition fix: PESSIMISTIC_WRITE lock on stock decrement in transaction - Idempotency key on PaymentIntent::create, reuse existing PI if stripeSessionId set - Disable checkout when event ended (server 400 + template hide) - Webhook deduplication via cache (24h TTL on stripe event.id) - Email validation (filter_var) in OrderController guest flow - JSON cart validation (structure check before processing) - Invitation expiration after 7 days (isExpired method + landing page message) - Stripe Checkout fallback when JS fails to load (noscript + redirect) Config externalization: - Move Stripe fees (STRIPE_FEE_RATE, STRIPE_FEE_FIXED) and admin email (ADMIN_EMAIL) to .env/services.yaml - Replace all hardcoded contact@e-cosplay.fr across 13 files - MailerService: getAdminEmail()/getAdminFrom(), default $from=null resolves to admin UX & Accessibility: - ARIA tabs: role=tablist/tab/tabpanel, aria-selected, keyboard nav (arrows, Home, End) - aria-label on cart +/- buttons and editor toolbar buttons - tabindex=0 on editor toolbar buttons for keyboard access - data-confirm handler in app.js (was only in admin.js) - Cart error feedback on checkout failure - Billet designer save feedback (loading/success/error states) - Stock polling every 30s with rupture/low stock badges - Back to event link on payment page Security: - HTML sanitizer: BLOCKED_TAGS list (script, style, iframe, svg, etc.) - content fully removed - Stripe polling timeout (15s max) with fallback redirect - Rate limiting on public order access (20/5min) - .catch() on all fetch() calls (sortable, billet-designer) Tests (92% PHP, 100% JS lines): - PCOV added to dev Dockerfile - Test DB setup: .env.test with DATABASE_URL, Redis auth, Meilisearch key - Rate limiter disabled in test env - Makefile: test_db_setup, test_db_reset, run_test_php, run_test_coverage_php/js - New tests: InvitationFlowTest (21), AuditServiceTest (4), ExportServiceTest (9), InvoiceServiceTest (4) - New tests: SuspendedUserSubscriberTest, RateLimiterSubscriberTest, MeilisearchServiceTest - New tests: Stripe webhook payment_failed (6) + charge.refunded (6) - New tests: BilletBuyer refund, User suspended, OrganizerInvitation expiration - JS tests: stock polling (6), data-confirm (2), copy-url restore (1), editor ARIA (2), XSS (9), tabs keyboard (9) - ESLint + PHP CS Fixer: 0 errors - SonarQube exclusions aligned with vitest coverage config Infra: - Meilisearch consistency command (app:meilisearch:check-consistency --fix) + cron daily 3am - MeilisearchService: getAllDocumentIds(), listIndexes() Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Serreau Jovann
149
tests/Command/MeilisearchConsistencyCommandTest.php
Normal file
149
tests/Command/MeilisearchConsistencyCommandTest.php
Normal file
@@ -0,0 +1,149 @@
|
||||
<?php
|
||||
|
||||
namespace App\Tests\Command;
|
||||
|
||||
use App\Command\MeilisearchConsistencyCommand;
|
||||
use App\Entity\BilletBuyer;
|
||||
use App\Entity\Event;
|
||||
use App\Entity\User;
|
||||
use App\Service\EventIndexService;
|
||||
use App\Service\MeilisearchService;
|
||||
use App\Service\OrderIndexService;
|
||||
use Doctrine\ORM\EntityManagerInterface;
|
||||
use Doctrine\ORM\EntityRepository;
|
||||
use PHPUnit\Framework\TestCase;
|
||||
use Symfony\Component\Console\Application;
|
||||
use Symfony\Component\Console\Tester\CommandTester;
|
||||
|
||||
class MeilisearchConsistencyCommandTest extends TestCase
|
||||
{
|
||||
private MeilisearchService $meilisearch;
|
||||
private EntityManagerInterface $em;
|
||||
private EventIndexService $eventIndex;
|
||||
private OrderIndexService $orderIndex;
|
||||
private CommandTester $tester;
|
||||
|
||||
protected function setUp(): void
|
||||
{
|
||||
$this->meilisearch = $this->createMock(MeilisearchService::class);
|
||||
$this->em = $this->createMock(EntityManagerInterface::class);
|
||||
$this->eventIndex = $this->createMock(EventIndexService::class);
|
||||
$this->orderIndex = $this->createMock(OrderIndexService::class);
|
||||
|
||||
$command = new MeilisearchConsistencyCommand(
|
||||
$this->meilisearch,
|
||||
$this->em,
|
||||
$this->eventIndex,
|
||||
$this->orderIndex,
|
||||
);
|
||||
|
||||
$app = new Application();
|
||||
$app->addCommand($command);
|
||||
$this->tester = new CommandTester($app->find('app:meilisearch:check-consistency'));
|
||||
}
|
||||
|
||||
public function testAllConsistent(): void
|
||||
{
|
||||
$this->meilisearch->method('listIndexes')->willReturn(['event_global', 'event_admin']);
|
||||
$this->meilisearch->method('indexExists')->willReturnCallback(
|
||||
fn (string $idx) => \in_array($idx, ['event_global', 'event_admin'], true)
|
||||
);
|
||||
$this->meilisearch->method('getAllDocumentIds')->willReturn([1, 2]);
|
||||
|
||||
$event1 = $this->createMock(Event::class);
|
||||
$event1->method('getId')->willReturn(1);
|
||||
$event2 = $this->createMock(Event::class);
|
||||
$event2->method('getId')->willReturn(2);
|
||||
|
||||
$eventRepo = $this->createMock(EntityRepository::class);
|
||||
$eventRepo->method('findBy')->willReturn([$event1, $event2]);
|
||||
$eventRepo->method('findAll')->willReturn([$event1, $event2]);
|
||||
|
||||
$userRepo = $this->createMock(EntityRepository::class);
|
||||
$userRepo->method('findBy')->willReturn([]);
|
||||
$userRepo->method('findAll')->willReturn([]);
|
||||
|
||||
$this->em->method('getRepository')->willReturnMap([
|
||||
[Event::class, $eventRepo],
|
||||
[User::class, $userRepo],
|
||||
[BilletBuyer::class, $this->createMock(EntityRepository::class)],
|
||||
]);
|
||||
|
||||
$this->tester->execute([]);
|
||||
$this->assertStringContainsString('All indexes are consistent', $this->tester->getDisplay());
|
||||
}
|
||||
|
||||
public function testMeilisearchUnreachable(): void
|
||||
{
|
||||
$this->meilisearch->method('listIndexes')->willThrowException(new \RuntimeException('Connection refused'));
|
||||
|
||||
$this->tester->execute([]);
|
||||
$this->assertStringContainsString('Meilisearch unreachable', $this->tester->getDisplay());
|
||||
$this->assertSame(1, $this->tester->getStatusCode());
|
||||
}
|
||||
|
||||
public function testDetectsOrphansAndMissing(): void
|
||||
{
|
||||
$this->meilisearch->method('listIndexes')->willReturn(['event_global', 'event_admin']);
|
||||
$this->meilisearch->method('indexExists')->willReturn(true);
|
||||
$this->meilisearch->method('getAllDocumentIds')->willReturn([1, 99]);
|
||||
|
||||
$event1 = $this->createMock(Event::class);
|
||||
$event1->method('getId')->willReturn(1);
|
||||
$event2 = $this->createMock(Event::class);
|
||||
$event2->method('getId')->willReturn(2);
|
||||
|
||||
$eventRepo = $this->createMock(EntityRepository::class);
|
||||
$eventRepo->method('findBy')->willReturn([$event1, $event2]);
|
||||
$eventRepo->method('findAll')->willReturn([$event1, $event2]);
|
||||
|
||||
$userRepo = $this->createMock(EntityRepository::class);
|
||||
$userRepo->method('findBy')->willReturn([]);
|
||||
$userRepo->method('findAll')->willReturn([]);
|
||||
|
||||
$this->em->method('getRepository')->willReturnMap([
|
||||
[Event::class, $eventRepo],
|
||||
[User::class, $userRepo],
|
||||
[BilletBuyer::class, $this->createMock(EntityRepository::class)],
|
||||
]);
|
||||
|
||||
$this->tester->execute([]);
|
||||
$output = $this->tester->getDisplay();
|
||||
$this->assertStringContainsString('orphan', $output);
|
||||
$this->assertStringContainsString('missing', $output);
|
||||
$this->assertStringContainsString('--fix', $output);
|
||||
}
|
||||
|
||||
public function testFixDeletesOrphansAndReindexes(): void
|
||||
{
|
||||
$this->meilisearch->method('listIndexes')->willReturn(['event_global', 'event_admin']);
|
||||
$this->meilisearch->method('indexExists')->willReturn(true);
|
||||
$this->meilisearch->method('getAllDocumentIds')->willReturn([1, 99]);
|
||||
|
||||
$event1 = $this->createMock(Event::class);
|
||||
$event1->method('getId')->willReturn(1);
|
||||
$event2 = $this->createMock(Event::class);
|
||||
$event2->method('getId')->willReturn(2);
|
||||
|
||||
$eventRepo = $this->createMock(EntityRepository::class);
|
||||
$eventRepo->method('findBy')->willReturn([$event1, $event2]);
|
||||
$eventRepo->method('findAll')->willReturn([$event1, $event2]);
|
||||
|
||||
$userRepo = $this->createMock(EntityRepository::class);
|
||||
$userRepo->method('findBy')->willReturn([]);
|
||||
$userRepo->method('findAll')->willReturn([]);
|
||||
|
||||
$this->em->method('getRepository')->willReturnMap([
|
||||
[Event::class, $eventRepo],
|
||||
[User::class, $userRepo],
|
||||
[BilletBuyer::class, $this->createMock(EntityRepository::class)],
|
||||
]);
|
||||
|
||||
$this->meilisearch->expects($this->atLeastOnce())->method('deleteDocuments');
|
||||
$this->eventIndex->expects($this->atLeastOnce())->method('indexEvent');
|
||||
|
||||
$this->tester->execute(['--fix' => true]);
|
||||
$output = $this->tester->getDisplay();
|
||||
$this->assertStringContainsString('Fixed', $output);
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user