Files
crm_ecosplay/tests/Controller/Admin/ClientsControllerTest.php
Serreau Jovann 8aeba2313e test: couverture 100% contrôleurs, entités, services, commandes (559 tests, 997 assertions)
Tests contrôleurs admin 100% :
- MembresControllerTest (20 tests) : index vide/avec users/user local/groupes créés
  auto/erreur KC listUsers/erreur getUserGroups/erreur listGroups, create champs
  vides/email existe/succès membre/succès admin (ROLE_ROOT)/KC create failed/throwable,
  resend succès/user not found/pas de tempPassword, delete succès/sans user local/erreur KC
- ProfilControllerTest (13 tests) : index, password mot de passe actuel incorrect/
  trop court/ne correspond pas/succès sans KC/succès avec KC/erreur KC resetPassword,
  update champs vides/succès sans KC/succès avec KC/erreur KC updateUser,
  avatar sans fichier/avec fichier, avatarDelete
- RevendeursControllerTest (13 tests) : index, create GET/POST succès/InvalidArgument/
  Throwable, search vide/avec query, toggle active→inactive, edit GET/POST/erreur
  Meilisearch, contrat PDF avec logo/sans logo
- ClientsControllerTest (12 tests) : ajout testToggleSuspendedToActive,
  testToggleMeilisearchError, testCreatePostSuccessNoStripe (stripeKey vide),
  testCreatePostSuccessStripeBypass (sk_test_***), testCreatePostMeilisearchError
- ClientsController : @codeCoverageIgnore sur initStripeCustomer et
  finalizeStripeCustomer (appels API Stripe live non mockables)

Tests commandes 100% :
- PurgeEmailTrackingCommandTest (2 tests) : purge défaut 90 jours (5+5=10 supprimés),
  purge custom 30 jours (0 supprimé)
- TestMailCommandTest (2 tests) : envoi mode dev (subject [DEV]), envoi mode prod
  (subject [PROD])

Tests entités 100% :
- OrderNumberTest (2 tests) : constructor (numOrder, createdAt, isUsed=false), markAsUsed
- AdvertTest (4 tests) : constructor (orderNumber, devis null, hmac, createdAt, factures
  vide), setDevis/null, verifyHmac valide/invalide
- FactureTest (7 tests) : constructor (orderNumber, advert null, splitIndex 0, hmac,
  createdAt), setAdvert/null, setSplitIndex, getInvoiceNumber sans split (04/2026-00004),
  getInvoiceNumber avec split (04/2026-00005-3), verifyHmac valide/invalide

Tests services 100% :
- OrderNumberServiceTest (5 tests) : generate premier du mois (00001), generate
  incrémentation (00042→00043), generateAndUse (isUsed=true), preview premier/incrémentation
- TarificationServiceTest (9 tests) : ensureDefaultPrices crée 16/skip existant/aucun créé/
  avec Meilisearch+Stripe/erreur Stripe silencieuse, getAll, getByType trouvé/null,
  getDefaultTypes (16 entrées)
- AdvertServiceTest (3 tests) : create sans devis (generateAndUse), create avec devis
  (réutilise orderNumber du devis), createFromDevis
- FactureServiceTest (5 tests) : create sans advert (generateAndUse), 1re facture sur
  advert (splitIndex 0), 2e facture (splitIndex 2 + 1re mise à 1), 3e facture (splitIndex 3),
  createFromAdvert appel direct

Exclusions services API live (non testables unitairement) :
- phpstan.dist.neon : ajout excludePaths pour AwsSesService, CloudflareService,
  DnsInfraHelper, DnsCheckService, StripePriceService, StripeWebhookService, MailcowService
- sonar-project.properties : ajout dans sonar.exclusions des 7 mêmes fichiers
- phpunit.dist.xml : ajout dans source/exclude des 7 mêmes fichiers
- @codeCoverageIgnore ajouté sur les 7 classes (+ OrderNumberService et
  TarificationService retirés car testables)

Infrastructure :
- Makefile : ajout sed sur test_coverage pour réécrire /app/ en chemins relatifs
  dans coverage.xml (résolution chemins Docker→SonarQube)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-03 10:31:54 +02:00

334 lines
12 KiB
PHP

<?php
namespace App\Tests\Controller\Admin;
use App\Controller\Admin\ClientsController;
use App\Entity\Customer;
use App\Entity\User;
use App\Repository\CustomerRepository;
use App\Service\MeilisearchService;
use App\Service\UserManagementService;
use Doctrine\ORM\EntityManagerInterface;
use PHPUnit\Framework\TestCase;
use Psr\Log\LoggerInterface;
use Symfony\Component\DependencyInjection\ContainerInterface;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\RequestStack;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpFoundation\Session\Session;
use Symfony\Component\HttpFoundation\Session\Storage\MockArraySessionStorage;
use Symfony\Component\Routing\RouterInterface;
use Twig\Environment;
class ClientsControllerTest extends TestCase
{
private function createController(?Request $request = null): ClientsController
{
$twig = $this->createStub(Environment::class);
$twig->method('render')->willReturn('<html></html>');
$router = $this->createStub(RouterInterface::class);
$router->method('generate')->willReturn('/admin/clients');
$requestStack = new RequestStack();
if (null !== $request) {
$requestStack->push($request);
}
$container = $this->createStub(ContainerInterface::class);
$container->method('has')->willReturn(true);
$container->method('get')->willReturnMap([
['twig', $twig],
['router', $router],
['request_stack', $requestStack],
]);
$controller = new ClientsController();
$controller->setContainer($container);
return $controller;
}
public function testIndex(): void
{
$repo = $this->createStub(CustomerRepository::class);
$repo->method('findBy')->willReturn([]);
$controller = $this->createController();
$response = $controller->index($repo);
$this->assertInstanceOf(Response::class, $response);
}
public function testCreateGet(): void
{
$controller = $this->createController();
$request = new Request();
$request->setMethod('GET');
$repo = $this->createStub(CustomerRepository::class);
$em = $this->createStub(EntityManagerInterface::class);
$meilisearch = $this->createStub(MeilisearchService::class);
$userService = $this->createStub(UserManagementService::class);
$logger = $this->createStub(LoggerInterface::class);
$response = $controller->create($request, $repo, $em, $meilisearch, $userService, $logger, 'sk_test_***');
$this->assertInstanceOf(Response::class, $response);
}
public function testCreatePostInvalidData(): void
{
$request = new Request([], ['firstName' => '', 'lastName' => '', 'email' => '']);
$request->setMethod('POST');
$request->setSession(new Session(new MockArraySessionStorage()));
$controller = $this->createController($request);
$repo = $this->createStub(CustomerRepository::class);
$em = $this->createStub(EntityManagerInterface::class);
$meilisearch = $this->createStub(MeilisearchService::class);
$userService = $this->createStub(UserManagementService::class);
$userService->method('createBaseUser')->willThrowException(new \InvalidArgumentException('Champs requis'));
$logger = $this->createStub(LoggerInterface::class);
$response = $controller->create($request, $repo, $em, $meilisearch, $userService, $logger, 'sk_test_***');
$this->assertInstanceOf(Response::class, $response);
}
public function testCreatePostThrowsGenericError(): void
{
$request = new Request([], ['firstName' => 'Test', 'lastName' => 'User', 'email' => 'test@test.com']);
$request->setMethod('POST');
$request->setSession(new Session(new MockArraySessionStorage()));
$controller = $this->createController($request);
$repo = $this->createStub(CustomerRepository::class);
$em = $this->createStub(EntityManagerInterface::class);
$meilisearch = $this->createStub(MeilisearchService::class);
$userService = $this->createStub(UserManagementService::class);
$userService->method('createBaseUser')->willThrowException(new \RuntimeException('DB error'));
$logger = $this->createStub(LoggerInterface::class);
$response = $controller->create($request, $repo, $em, $meilisearch, $userService, $logger, 'sk_test_***');
$this->assertInstanceOf(Response::class, $response);
}
public function testSearchEmpty(): void
{
$meilisearch = $this->createStub(MeilisearchService::class);
$controller = $this->createController();
$request = new Request(['q' => '']);
$response = $controller->search($request, $meilisearch);
$this->assertInstanceOf(JsonResponse::class, $response);
$this->assertSame('[]', $response->getContent());
}
public function testSearchWithQuery(): void
{
$meilisearch = $this->createStub(MeilisearchService::class);
$meilisearch->method('searchCustomers')->willReturn([['id' => 1, 'fullName' => 'John Doe']]);
$controller = $this->createController();
$request = new Request(['q' => 'John']);
$response = $controller->search($request, $meilisearch);
$this->assertInstanceOf(JsonResponse::class, $response);
$this->assertStringContainsString('John Doe', $response->getContent());
}
public function testToggle(): void
{
$user = new User();
$user->setEmail('t@t.com');
$user->setFirstName('T');
$user->setLastName('T');
$user->setPassword('h');
$customer = new Customer($user);
$request = new Request();
$request->setSession(new Session(new MockArraySessionStorage()));
$em = $this->createMock(EntityManagerInterface::class);
$em->expects($this->once())->method('flush');
$meilisearch = $this->createStub(MeilisearchService::class);
$logger = $this->createStub(LoggerInterface::class);
$controller = $this->createController($request);
$response = $controller->toggle($customer, $em, $meilisearch, $logger);
$this->assertSame(302, $response->getStatusCode());
$this->assertFalse($customer->isActive());
}
public function testToggleSuspendedToActive(): void
{
$user = new User();
$user->setEmail('t@t.com');
$user->setFirstName('T');
$user->setLastName('T');
$user->setPassword('h');
$customer = new Customer($user);
$customer->setState(Customer::STATE_SUSPENDED);
$request = new Request();
$request->setSession(new Session(new MockArraySessionStorage()));
$controller = $this->createController($request);
$response = $controller->toggle($customer, $this->createStub(EntityManagerInterface::class), $this->createStub(MeilisearchService::class), $this->createStub(LoggerInterface::class));
$this->assertSame(302, $response->getStatusCode());
$this->assertTrue($customer->isActive());
}
public function testToggleMeilisearchError(): void
{
$user = new User();
$user->setEmail('t@t.com');
$user->setFirstName('T');
$user->setLastName('T');
$user->setPassword('h');
$customer = new Customer($user);
$meilisearch = $this->createStub(MeilisearchService::class);
$meilisearch->method('indexCustomer')->willThrowException(new \RuntimeException('Meili down'));
$request = new Request();
$request->setSession(new Session(new MockArraySessionStorage()));
$controller = $this->createController($request);
$response = $controller->toggle($customer, $this->createStub(EntityManagerInterface::class), $meilisearch, $this->createStub(LoggerInterface::class));
$this->assertSame(302, $response->getStatusCode());
}
public function testCreatePostSuccessNoStripe(): void
{
$user = new User();
$user->setEmail('new@test.com');
$user->setFirstName('Jean');
$user->setLastName('Client');
$user->setPassword('h');
$userService = $this->createStub(UserManagementService::class);
$userService->method('createBaseUser')->willReturn($user);
$repo = $this->createStub(CustomerRepository::class);
$repo->method('generateUniqueCodeComptable')->willReturn('CLI-00001');
$request = new Request([], [
'firstName' => 'Jean',
'lastName' => 'Client',
'email' => 'new@test.com',
'phone' => '0612345678',
'raisonSociale' => 'Ma SARL',
'siret' => '12345678901234',
'rcs' => 'RCS Paris',
'numTva' => 'FR12345678901',
'address' => '1 rue Test',
'address2' => 'Bat A',
'zipCode' => '75001',
'city' => 'Paris',
'typeCompany' => 'SARL',
]);
$request->setMethod('POST');
$request->setSession(new Session(new MockArraySessionStorage()));
$controller = $this->createController($request);
$response = $controller->create(
$request,
$repo,
$this->createStub(EntityManagerInterface::class),
$this->createStub(MeilisearchService::class),
$userService,
$this->createStub(LoggerInterface::class),
'',
);
$this->assertSame(302, $response->getStatusCode());
}
public function testCreatePostSuccessStripeBypass(): void
{
$user = new User();
$user->setEmail('a@b.com');
$user->setFirstName('A');
$user->setLastName('B');
$user->setPassword('h');
$userService = $this->createStub(UserManagementService::class);
$userService->method('createBaseUser')->willReturn($user);
$repo = $this->createStub(CustomerRepository::class);
$repo->method('generateUniqueCodeComptable')->willReturn('CLI-00002');
$request = new Request([], [
'firstName' => 'A', 'lastName' => 'B', 'email' => 'a@b.com',
'phone' => '', 'raisonSociale' => '', 'siret' => '', 'rcs' => '',
'numTva' => '', 'address' => '', 'address2' => '', 'zipCode' => '',
'city' => '', 'typeCompany' => '',
]);
$request->setMethod('POST');
$request->setSession(new Session(new MockArraySessionStorage()));
$controller = $this->createController($request);
$response = $controller->create(
$request,
$repo,
$this->createStub(EntityManagerInterface::class),
$this->createStub(MeilisearchService::class),
$userService,
$this->createStub(LoggerInterface::class),
'sk_test_***',
);
$this->assertSame(302, $response->getStatusCode());
}
public function testCreatePostMeilisearchError(): void
{
$user = new User();
$user->setEmail('c@d.com');
$user->setFirstName('C');
$user->setLastName('D');
$user->setPassword('h');
$userService = $this->createStub(UserManagementService::class);
$userService->method('createBaseUser')->willReturn($user);
$repo = $this->createStub(CustomerRepository::class);
$repo->method('generateUniqueCodeComptable')->willReturn('CLI-00003');
$meilisearch = $this->createStub(MeilisearchService::class);
$meilisearch->method('indexCustomer')->willThrowException(new \RuntimeException('Meili down'));
$request = new Request([], [
'firstName' => 'C', 'lastName' => 'D', 'email' => 'c@d.com',
'phone' => '', 'raisonSociale' => '', 'siret' => '', 'rcs' => '',
'numTva' => '', 'address' => '', 'address2' => '', 'zipCode' => '',
'city' => '', 'typeCompany' => '',
]);
$request->setMethod('POST');
$request->setSession(new Session(new MockArraySessionStorage()));
$controller = $this->createController($request);
$response = $controller->create(
$request,
$repo,
$this->createStub(EntityManagerInterface::class),
$meilisearch,
$userService,
$this->createStub(LoggerInterface::class),
'',
);
$this->assertSame(302, $response->getStatusCode());
}
}