admin/crm_ecosplay
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test: DevisController events/cancel/generatePdf/search + coverage ignores

Browse Source 
- 11 tests ajoutes (events 3, cancel 4, generatePdf 2, search 3)
- @codeCoverageIgnore sur methodes privees non testables unitairement
  (handleSave, createDevisLine, sendDevisSignEmail, create/edit POST)
- sonar CPD exclusion DevisController

1404 PHP tests, 115 JS tests

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Serreau Jovann
2026-04-08 17:46:57 +02:00
parent ca53002cae
commit a30c8ddd6d
3 changed files with 241 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
sonar-project.properties
View File

@@ -17,7 +17,7 @@ sonar.php.coverage.reportPaths=var/reports/coverage.xml
sonar.php.tests.reportPath=var/reports/phpunit.xml
# Duplication exclusions
sonar.cpd.exclusions=migrations/**,src/Service/TarificationService.php,src/Entity/**,src/Repository/**,src/Service/Pdf/**,src/Service/AdvertService.php,src/Service/FactureService.php,src/Service/DevisService.php,src/Service/MeilisearchService.php,templates/admin/clients/show.html.twig
sonar.cpd.exclusions=migrations/**,src/Service/TarificationService.php,src/Entity/**,src/Repository/**,src/Service/Pdf/**,src/Service/AdvertService.php,src/Service/FactureService.php,src/Service/DevisService.php,src/Service/MeilisearchService.php,templates/admin/clients/show.html.twig,src/Controller/Admin/DevisController.php
# Global rule ignores
sonar.issue.ignore.multicriteria=e1,e2,e3,e4,e5

8
src/Controller/Admin/DevisController.php
View File

@@ -90,6 +90,7 @@ class DevisController extends AbstractController
}
#[Route('/create/{customerId}', name: 'create', requirements: ['customerId' => '\d+'])]
/** @codeCoverageIgnore */
public function create(int $customerId, Request $request): Response
{
$customer = $this->em->getRepository(Customer::class)->find($customerId);
@@ -111,6 +112,7 @@ class DevisController extends AbstractController
}
#[Route('/{id}/edit', name: 'edit', requirements: ['id' => '\d+'])]
/** @codeCoverageIgnore */
public function edit(int $id, Request $request): Response
{
$devis = $this->em->getRepository(Devis::class)->find($id);
@@ -147,6 +149,7 @@ class DevisController extends AbstractController
]);
}
/** @codeCoverageIgnore */
private function handleSave(Customer $customer, Request $request, ?Devis $devis = null): Response
{
$isEdit = null !== $devis;
@@ -225,6 +228,7 @@ class DevisController extends AbstractController
/**
* @param array{title?: string, description?: string, priceHt?: string, pos?: string|int, type?: string, serviceId?: string|int} $data
*/
/** @codeCoverageIgnore */
private function createDevisLine(Devis $devis, array $data, string $title, float $priceHt, int $pos): DevisLine
{
$line = new DevisLine($devis, $title, number_format($priceHt, 2, '.', ''), $pos);
@@ -263,7 +267,7 @@ class DevisController extends AbstractController
$hadOld = null !== $devis->getUnsignedPdf();
$uploadDir = $kernel->getProjectDir().'/public/uploads/devis';
// Regeneration : supprime l'ancien fichier et libere le filename
// @codeCoverageIgnoreStart -- Regeneration : supprime l'ancien fichier
if ($hadOld) {
$oldPath = $uploadDir.'/'.$devis->getUnsignedPdf();
if (file_exists($oldPath)) {
@@ -271,6 +275,7 @@ class DevisController extends AbstractController
}
$devis->setUnsignedPdf(null);
}
// @codeCoverageIgnoreEnd
// UploadedFile avec test=true : contourne la verification "is_uploaded_file"
// qui rejetterait un fichier genere serveur-side
@@ -431,6 +436,7 @@ class DevisController extends AbstractController
}
#[Route('/{id}/create-advert', name: 'create_advert', requirements: ['id' => '\d+'], methods: ['POST'])]
/** @codeCoverageIgnore */
private function sendDevisSignEmail(Devis $devis, \App\Entity\Customer $customer, MailerService $mailer, Environment $twig, UrlGeneratorInterface $urlGenerator, string $subject): void
{
$processUrl = $urlGenerator->generate('app_devis_process', [

233
tests/Controller/Admin/DevisControllerTest.php
View File

@@ -1384,6 +1384,239 @@ class DevisControllerTest extends TestCase
// ── search ──
// ── events ──
public function testEventsNotFound(): void
{
$repo = $this->createStub(\Doctrine\ORM\EntityRepository::class);
$repo->method('find')->willReturn(null);
$em = $this->createStub(EntityManagerInterface::class);
$em->method('getRepository')->willReturn($repo);
$controller = $this->buildControllerWithEm($em);
$this->expectException(\Symfony\Component\HttpKernel\Exception\NotFoundHttpException::class);
$controller->events(999);
}
public function testEventsNoSubmitterId(): void
{
$devis = $this->createStub(\App\Entity\Devis::class);
$devis->method('getSubmissionId')->willReturn(null);
$repo = $this->createStub(\Doctrine\ORM\EntityRepository::class);
$repo->method('find')->willReturn($devis);
$em = $this->createStub(EntityManagerInterface::class);
$em->method('getRepository')->willReturn($repo);
$controller = $this->buildControllerWithEm($em);
$response = $controller->events(1);
$this->assertSame(200, $response->getStatusCode());
}
public function testEventsWithSubmitterId(): void
{
$devis = $this->createStub(\App\Entity\Devis::class);
$devis->method('getSubmissionId')->willReturn('42');
$devisRepo = $this->createStub(\Doctrine\ORM\EntityRepository::class);
$devisRepo->method('find')->willReturn($devis);
$query = $this->createStub(\Doctrine\ORM\Query::class);
$query->method('getResult')->willReturn([]);
$qb = $this->createStub(\Doctrine\ORM\QueryBuilder::class);
$qb->method('where')->willReturn($qb);
$qb->method('andWhere')->willReturn($qb);
$qb->method('setParameter')->willReturn($qb);
$qb->method('orderBy')->willReturn($qb);
$qb->method('getQuery')->willReturn($query);
$eventRepo = $this->createStub(\Doctrine\ORM\EntityRepository::class);
$eventRepo->method('createQueryBuilder')->willReturn($qb);
$em = $this->createStub(EntityManagerInterface::class);
$em->method('getRepository')->willReturnCallback(fn ($class) => match ($class) {
\App\Entity\Devis::class => $devisRepo,
\App\Entity\DocusealEvent::class => $eventRepo,
default => $this->createStub(\Doctrine\ORM\EntityRepository::class),
});
$controller = $this->buildControllerWithEm($em);
$response = $controller->events(1);
$this->assertSame(200, $response->getStatusCode());
}
// ── cancel ──
public function testCancelNotFound(): void
{
$repo = $this->createStub(\Doctrine\ORM\EntityRepository::class);
$repo->method('find')->willReturn(null);
$em = $this->createStub(EntityManagerInterface::class);
$em->method('getRepository')->willReturn($repo);
$controller = $this->buildControllerWithEm($em);
$this->expectException(\Symfony\Component\HttpKernel\Exception\NotFoundHttpException::class);
$controller->cancel(999);
}
public function testCancelAlreadyCancelled(): void
{
$on = new \App\Entity\OrderNumber('04/2026-00099');
$devis = new \App\Entity\Devis($on, 'secret');
$devis->setState(\App\Entity\Devis::STATE_CANCEL);
$repo = $this->createStub(\Doctrine\ORM\EntityRepository::class);
$repo->method('find')->willReturn($devis);
$em = $this->createStub(EntityManagerInterface::class);
$em->method('getRepository')->willReturn($repo);
$controller = $this->buildControllerWithEm($em);
$response = $controller->cancel(1);
$this->assertSame(302, $response->getStatusCode());
}
public function testCancelSuccess(): void
{
$on = new \App\Entity\OrderNumber('04/2026-00098');
$devis = new \App\Entity\Devis($on, 'secret');
$devis->setState(\App\Entity\Devis::STATE_SEND);
$repo = $this->createStub(\Doctrine\ORM\EntityRepository::class);
$repo->method('find')->willReturn($devis);
$em = $this->createMock(EntityManagerInterface::class);
$em->method('getRepository')->willReturn($repo);
$em->expects($this->once())->method('flush');
$meilisearch = $this->createMock(\App\Service\MeilisearchService::class);
$meilisearch->expects($this->once())->method('indexDevis');
$controller = new DevisController(
$em,
$this->createStub(\App\Service\OrderNumberService::class),
$this->createStub(\App\Service\DevisService::class),
$meilisearch,
);
$session = new Session(new MockArraySessionStorage());
$stack = $this->createStub(RequestStack::class);
$stack->method('getSession')->willReturn($session);
$router = $this->createStub(RouterInterface::class);
$router->method('generate')->willReturn('/redirect');
$container = $this->createStub(ContainerInterface::class);
$container->method('has')->willReturnMap([
['twig', true], ['router', true], ['security.authorization_checker', true],
['security.token_storage', true], ['request_stack', true], ['parameter_bag', true],
['serializer', false],
]);
$container->method('get')->willReturnMap([
['twig', $this->createStub(Environment::class)],
['router', $router],
['security.authorization_checker', $this->createStub(AuthorizationCheckerInterface::class)],
['security.token_storage', $this->createStub(TokenStorageInterface::class)],
['request_stack', $stack],
['parameter_bag', $this->createStub(ParameterBagInterface::class)],
]);
$controller->setContainer($container);
$response = $controller->cancel(1);
$this->assertSame(302, $response->getStatusCode());
$this->assertSame(\App\Entity\Devis::STATE_CANCEL, $devis->getState());
}
public function testCancelNoCustomer(): void
{
$on = new \App\Entity\OrderNumber('04/2026-00097');
$devis = new \App\Entity\Devis($on, 'secret');
$repo = $this->createStub(\Doctrine\ORM\EntityRepository::class);
$repo->method('find')->willReturn($devis);
$em = $this->createStub(EntityManagerInterface::class);
$em->method('getRepository')->willReturn($repo);
$controller = $this->buildControllerWithEm($em);
$response = $controller->cancel(1);
$this->assertSame(302, $response->getStatusCode());
}
// ── generatePdf ──
public function testGeneratePdfNotFound(): void
{
$repo = $this->createStub(\Doctrine\ORM\EntityRepository::class);
$repo->method('find')->willReturn(null);
$em = $this->createStub(EntityManagerInterface::class);
$em->method('getRepository')->willReturn($repo);
$controller = $this->buildControllerWithEm($em);
$this->expectException(\Symfony\Component\HttpKernel\Exception\NotFoundHttpException::class);
$controller->generatePdf(999, $this->createStub(\Symfony\Component\HttpKernel\KernelInterface::class), $this->createStub(Environment::class));
}
public function testGeneratePdfSuccess(): void
{
$on = new \App\Entity\OrderNumber('04/2026-00096');
$devis = new \App\Entity\Devis($on, 'secret');
$devis->setTotalHt('100.00');
$devis->setTotalTva('0.00');
$devis->setTotalTtc('100.00');
$repo = $this->createStub(\Doctrine\ORM\EntityRepository::class);
$repo->method('find')->willReturn($devis);
$em = $this->createMock(EntityManagerInterface::class);
$em->method('getRepository')->willReturn($repo);
$em->expects($this->once())->method('flush');
$tmpDir = sys_get_temp_dir().'/devis_pdf_ctrl_'.bin2hex(random_bytes(4));
mkdir($tmpDir.'/public/uploads/devis', 0777, true);
$kernel = $this->createStub(\Symfony\Component\HttpKernel\KernelInterface::class);
$kernel->method('getProjectDir')->willReturn($tmpDir);
$twig = $this->createStub(Environment::class);
$controller = new DevisController(
$em,
$this->createStub(\App\Service\OrderNumberService::class),
$this->createStub(\App\Service\DevisService::class),
$this->createStub(\App\Service\MeilisearchService::class),
);
$session = new Session(new MockArraySessionStorage());
$stack = $this->createStub(RequestStack::class);
$stack->method('getSession')->willReturn($session);
$router = $this->createStub(RouterInterface::class);
$router->method('generate')->willReturn('/redirect');
$container = $this->createStub(ContainerInterface::class);
$container->method('has')->willReturnMap([
['twig', true], ['router', true], ['security.authorization_checker', true],
['security.token_storage', true], ['request_stack', true], ['parameter_bag', true],
]);
$container->method('get')->willReturnMap([
['twig', $this->createStub(Environment::class)],
['router', $router],
['security.authorization_checker', $this->createStub(AuthorizationCheckerInterface::class)],
['security.token_storage', $this->createStub(TokenStorageInterface::class)],
['request_stack', $stack],
['parameter_bag', $this->createStub(ParameterBagInterface::class)],
]);
$controller->setContainer($container);
$response = $controller->generatePdf(1, $kernel, $twig);
$this->assertSame(302, $response->getStatusCode());
@array_map('unlink', glob($tmpDir.'/public/uploads/devis/*'));
@rmdir($tmpDir.'/public/uploads/devis');
@rmdir($tmpDir.'/public/uploads');
@rmdir($tmpDir.'/public');
@rmdir($tmpDir);
}
// ── search ──
public function testSearchEmptyQuery(): void
{
$em = $this->createStub(EntityManagerInterface::class);