admin/crm_ecosplay
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: SonarQube StatsController - constantes, CC, variable inutilisee

Browse Source 
- DQL_BETWEEN_DATES, DQL_IS_PAID, COLOR_GOLD constantes
- Suppression $paymentsByMethod inutilisee
- getServiceStats CC 23->~10 : extraction groupServiceLines,
  mergeServiceGroups, resolveServiceStatus
- Ternaire imbrique remplace par resolveServiceStatus()
- Tests mis a jour (retrait getPaymentsByMethod de toutes les sequences)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Serreau Jovann
2026-04-08 13:40:01 +02:00
parent 89f73f0ccf
commit 2ec4bb33c1
2 changed files with 64 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tests/Controller/Admin/StatsControllerTest.php
View File

@@ -215,7 +215,7 @@ class StatsControllerTest extends TestCase
[$paidFacture, $unpaidFacture], // 1. getFactureStats
[], // 2. getPaymentStats
[], // 3. getCoutPrestataire
[], // 4. getPaymentsByMethod
[], [], [], [], [], [], // 5. getMonthlyEvolution (6 months)
[$paidFacture], // 6. getServiceStats
];
@@ -246,7 +246,7 @@ class StatsControllerTest extends TestCase
[], // 1. getFactureStats
[$payment, $paymentNoMethod], // 2. getPaymentStats
[], // 3. getCoutPrestataire
[$payment, $paymentNoMethod], // 4. getPaymentsByMethod
[], [], [], [], [], [], // 5. getMonthlyEvolution
[], // 6. getServiceStats
];
@@ -309,7 +309,7 @@ class StatsControllerTest extends TestCase
[$facture], // 1. getFactureStats
[], // 2. getPaymentStats
[], // 3. getCoutPrestataire
[], // 4. getPaymentsByMethod
[], [], [], [], [], [], // 5. getMonthlyEvolution
[$facture], // 6. getServiceStats
];
@@ -335,7 +335,7 @@ class StatsControllerTest extends TestCase
[], // 1. getFactureStats
[], // 2. getPaymentStats
[$fp], // 3. getCoutPrestataire
[], // 4. getPaymentsByMethod
[], [], [], [], [], [], // 5. getMonthlyEvolution
[], // 6. getServiceStats
];
@@ -366,7 +366,7 @@ class StatsControllerTest extends TestCase
[$facture], // 1. getFactureStats
[], // 2. getPaymentStats
[], // 3. getCoutPrestataire
[], // 4. getPaymentsByMethod
[], [], [], [], [], [], // 5. getMonthlyEvolution
[$facture], // 6. getServiceStats
];
@@ -401,7 +401,7 @@ class StatsControllerTest extends TestCase
[$facture], // 1. getFactureStats
[], // 2. getPaymentStats
[$fp], // 3. getCoutPrestataire
[], // 4. getPaymentsByMethod
[], [], [], [], [], [], // 5. getMonthlyEvolution
[$facture], // 6. getServiceStats
];
@@ -443,7 +443,7 @@ class StatsControllerTest extends TestCase
[], // 1. getFactureStats
[], // 2. getPaymentStats
[], // 3. getCoutPrestataire
[], // 4. getPaymentsByMethod
[$paidFacture], [$paidFacture], [$paidFacture], [], [], [], // 5. getMonthlyEvolution
[], // 6. getServiceStats
];